core/trie: persist TrieJournal to journal file instead of kv database#2341
Merged
zzzckck merged 15 commits intobnb-chain:developfrom Apr 15, 2024
Merged
core/trie: persist TrieJournal to journal file instead of kv database#2341zzzckck merged 15 commits intobnb-chain:developfrom
zzzckck merged 15 commits intobnb-chain:developfrom
Conversation
426ee1f to
37ffdfb
Compare
30d1328 to
a63a4b9
Compare
a63a4b9 to
239cdb1
Compare
fynnss
reviewed
Apr 8, 2024
fynnss
reviewed
Apr 9, 2024
65cf980 to
88efafc
Compare
Collaborator
|
The solution is ok for me, it would bring some advantages: It can be merged once there are >2 approval. |
88efafc to
4e89289
Compare
RenRick
reviewed
Apr 9, 2024
fynnss
reviewed
Apr 10, 2024
fynnss
reviewed
Apr 10, 2024
core: fix some comment core: rename some variable
ae50a33 to
af15ebf
Compare
buddh0
approved these changes
Apr 12, 2024
setunapo
approved these changes
Apr 15, 2024
zzzckck
approved these changes
Apr 15, 2024
This was referenced Apr 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides another way to persist TrieJournal by write it into a log file instead of a kv database.
Use
--journalFileflag to enable/disable the journal file feature.Rationale
Persisting TrieJournal to KV database will cause problems below
Changes:
Data Format
Journal Version
Disk Root
Disk Layer
--
**Layer Length**-- Root
-- State ID
-- Buffer Nodes
--
**Layer Checksum**Diff Layer
--
**Layer Length**-- Root
-- Block
-- Trie Nodes
-- Journal Accounts
--
**Layer Checksum**Journal Path: geth/chaindata/ancient/state.journal
Checksum: SHA256
Testing
Function test
kill -15signal, the journal is persisted with a size consistent with the file.geth/chaindata/ancient/state.journal) and restart.Performance test
Scenario: Using TestJournal, each layer has 4K and 8K account operations.
Conclusion: The use of Journal WAL and storing trieJournalKey directly into kvdb results in nearly identical WAL write times during shutdown and WAL read/parsing times during startup.