feat: mev metrics#2317
Merged
zzzckck merged 3 commits intobnb-chain:developfrom Mar 21, 2024
irrun:re/metrics
Merged
Conversation
added 2 commits
March 21, 2024 09:43
unclezoro
reviewed
Mar 21, 2024
miner/worker.go
Outdated
|
|
||
| // when out-turn, use bestWork to prevent bundle leakage. | ||
| // when in-turn, compare with remote work. | ||
| builder := bestWork.coinbase |
Contributor
There was a problem hiding this comment.
I think the coinbase always the signer, not builder
unclezoro
approved these changes
Mar 21, 2024
zzzckck
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: add some metrics to monitor mev