internal/ethapi: add net_nodeInfo#2307
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Mar 21, 2024
Merged
Conversation
zzzckck
approved these changes
Mar 20, 2024
zlacfzy
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
net_nodeInfoRPC method. It is the same asadmin_nodeInfo.Rationale
The reason why
net_nodeInfois introduced even thoughadmin_nodeInfoalready exists is because some admin methods can control the behavior of the node. If a node were to be compromised with the admin namespace enabled, then the node could potentially stop functioning.On the other hand, having access to retrieving the node information is extremely useful, especially when running an infrastructure. The content of the node info doesn't reveal sensitive information as well, so it could be added to the net namespace safely.
Another consideration is to remove
admin_nodeInfoand replace withnet_nodeInfo. This is possible, but this will contradict with the documentation of geth upstream. So in my opinion, there's no harm keeping both.Example