cmd, node: initialize ports with --instance#2298
Merged
zzzckck merged 2 commits intobnb-chain:developfrom Mar 21, 2024
Merged
Conversation
zzzckck
previously approved these changes
Mar 19, 2024
zlacfzy
previously approved these changes
Mar 21, 2024
zzzckck
approved these changes
Mar 21, 2024
brilliant-lx
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new CLI flag called
--instance <value>, used to configure ports when running multiple nodes on the same machine to avoid port conflicts. This is only applicable forport, authrpc.port, discovery,port, http.port, ws.port.The calculation of port numbers is as follows:
In a scenario where the user specify both
--instanceand the supported port list (i.e.port, authrpc.port, ...), then the ports specified will supersede the port values configured by--instance.Example
Usage:
geth --instance 2Usage:
geth --instance 2 --authrpc.port 8551Usage:
geth --instance 201Credits
This flag is inspired by reth.