Skip to content

cmd/utils, core: only full sync for fast nodes#2280

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
weiihann:develop/fast-no-snap
Mar 21, 2024
Merged

cmd/utils, core: only full sync for fast nodes#2280
zzzckck merged 1 commit intobnb-chain:developfrom
weiihann:develop/fast-no-snap

Conversation

@weiihann
Copy link
Copy Markdown
Contributor

@weiihann weiihann commented Mar 13, 2024

Description

This PR enforces a rule such that when tries-verify-mode is not local, it will always default to full sync instead of snap sync.

Rationale

Snap sync is not supported on fast nodes.

Example

INFO [03-13|13:52:26.157] Starting Geth on BSC mainnet...
INFO [03-13|13:52:26.157] Bumping default cache on mainnet         provided=1024 updated=4096
INFO [03-13|13:52:26.159] Maximum peer count                       ETH=50 total=50
WARN [03-13|13:52:26.163] Only local TriesVerifyMode can support snap sync, resetting to full sync mode=none
...

Changes

  • Fixed minor typo

@zzzckck zzzckck merged commit fd284c7 into bnb-chain:develop Mar 21, 2024
This was referenced Mar 21, 2024
Merged
Merged
@Pjrich1313 Pjrich1313 mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zlacfzy zlacfzy zlacfzy approved these changes

@zzzckck zzzckck zzzckck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weiihann @zlacfzy @zzzckck