4844 on bsc by buddh0 · Pull Request #2279 · bnb-chain/bsc

buddh0 · 2024-03-13T03:05:32Z

Description

BSC will support Cancun EIPs, check out Tycho hard fork plan. Other EIPs except EIP-4844 are already supported. But the implementation of EIP-4844 will be the big one and it will be different on BSC, mainly the blob part, as Ethereum store and propagate blobs in its consensus layer, while BSC doesn't have it. BSC need to implement in execution layer.

This PR will implement the EIP-4844 on BSC, there are some docs you may refer:

Rationale

Check out the motivation part of BEP-336: https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-336.md#4-motivation

Example

NA

Changes

New transaction type(type: 0x3), Blob-Carrying Transaction, its definitin will be same as Ethereum.
New RPC APIs, mainly to support query of Blobs.
New blobs related storage in MainDB(level or pebble) and AncientDb.

.github/workflows/build-test.yml

NathanBSC · 2024-03-13T03:18:30Z

need add logic to add the blobfee as validator income instead of burning it

eth/protocols/eth/protocol.go

eth/fetcher/block_fetcher.go

consensus/parlia/parlia.go

core/blockchain.go

core/types/block.go

buddh0 · 2024-03-15T10:38:25Z

need add logic to add the blobfee as validator income instead of burning it

solved

cmd/utils/flags.go

core/blockchain.go

core/rawdb/freezer.go

zzzckck

LGTM

internal/ethapi/api.go

consensus/misc/eip4844/eip4844.go

pool: switch ON blobpool+no reannotx

* chainconfig: use cancun fork for BSC; feat: fill WithdrawalsHash when BSC enable cancun fork; * rawdb: support to CRUD blobs; freezer: support to freeze block blobs; * freezer: support to freeze block blobs; * blockchain: add blob cache & blob query helper; * blockchain: add blob cache & blob query helper; * freezer: refactor addition table logic, add uts; * blobexpiry: add more extra expiry time, and logs; * ci: fix UT fails; * fix: fix some PR review comments; * parlia: implement IsDataAvailable function; * blob: refactor blob transfer logic; * blob: support config blob extra reserve;

* blob: implement min&max gas price logic; blob: change some key parameters; * blockchian: support import side chain; * blobpool: reject the banned address; * blockchain: add chasing head for DA check; * params: update blob related config; * blockchain: opt data available checking performance; dataavailability: add more UTs; * blockchain: opt data available checking performance; dataavailability: add more UTs; * ci: fix failed UTs; * ci: fix failed UTs; * params: modify blob related params; * gasprice: support BEP-336 blob gas price calculate; * ci: fix some broken UTs;

* ci: temp enable blobtx branch ci run; * Switch ON blobpool & ensure Cancun hardfork can occur (#2223) pool: switch ON blobpool+no reannotx * feat: support blob storage & miscs; (#2229) * chainconfig: use cancun fork for BSC; feat: fill WithdrawalsHash when BSC enable cancun fork; * rawdb: support to CRUD blobs; freezer: support to freeze block blobs; * freezer: support to freeze block blobs; * blockchain: add blob cache & blob query helper; * blockchain: add blob cache & blob query helper; * freezer: refactor addition table logic, add uts; * blobexpiry: add more extra expiry time, and logs; * ci: fix UT fails; * fix: fix some PR review comments; * parlia: implement IsDataAvailable function; * blob: refactor blob transfer logic; * blob: support config blob extra reserve; * blockchian: support to import block with blob & blobGasFee; (#2260) * blob: implement min&max gas price logic; blob: change some key parameters; * blockchian: support import side chain; * blobpool: reject the banned address; * blockchain: add chasing head for DA check; * params: update blob related config; * blockchain: opt data available checking performance; dataavailability: add more UTs; * blockchain: opt data available checking performance; dataavailability: add more UTs; * ci: fix failed UTs; * ci: fix failed UTs; * params: modify blob related params; * gasprice: support BEP-336 blob gas price calculate; * ci: fix some broken UTs; * fix failed check for WithdrawalsHash (#2276) * eth: include sidecars in fitering of body * core: refactor sidecars name * eth: sidecars type refactor * core: remove extra from bad merge * eth: fix handlenewblock test after merge --------- Co-authored-by: GalaIO <GalaIO@users.noreply.github.com> Co-authored-by: buddho <galaxystroller@gmail.com>

* internal/api: implement eth_getBlobSidecars && eth_getBlobSidecarByTxHash * internal/api: implement eth_getBlobSidecars && eth_getBlobSidecarByTxHash * internal/api: fix comments * internal/api: fix comments * internal/api: fix comments * internal/api: fix comments

ci: fix some failed UTs; sync: add more UTs for blob syncing;

…#2301)

…obSidecarByTxHash (#2300)

* fix: fix some validation issues & ancient reset; * fix: fix some UTs fails; * fix: fix some UTs fails;

NathanBSC · 2024-03-21T08:53:55Z

mev module should be adapted

* blobsidecar: add new sidecar struct with metadata; * blobfee: add UT to check blob fee reward; * fix: fix some UTs fails & comments;

core/rawdb/chain_freezer.go

* core: more check for validity of sidecars core/rawdb: optimize write block with sidecars core/rawdb: rollback interface freezeRange * core: fix TestIsDataAvailable

rollback interface of NewFreezer remove ci for blobtx

buddh0 · 2024-03-22T07:04:12Z

mev module should be adapted

fixed

buddh0 · 2024-03-22T07:04:56Z

need add logic to add the blobfee as validator income instead of burning it

solved

zzzckck

LGTM👍

buddh0 changed the title ~~Blobtx~~ 4844 on bsc Mar 13, 2024

buddh0 commented Mar 13, 2024

View reviewed changes

.github/workflows/build-test.yml Outdated Show resolved Hide resolved

NathanBSC reviewed Mar 13, 2024

View reviewed changes

eth/protocols/eth/protocol.go Outdated Show resolved Hide resolved

NathanBSC reviewed Mar 13, 2024

View reviewed changes

eth/fetcher/block_fetcher.go Outdated Show resolved Hide resolved

zzzckck reviewed Mar 13, 2024

View reviewed changes

consensus/parlia/parlia.go Show resolved Hide resolved

zzzckck reviewed Mar 13, 2024

View reviewed changes

core/blockchain.go Outdated Show resolved Hide resolved

zzzckck reviewed Mar 13, 2024

View reviewed changes

core/types/block.go Outdated Show resolved Hide resolved

NathanBSC reviewed Mar 15, 2024

View reviewed changes

cmd/utils/flags.go Show resolved Hide resolved

NathanBSC reviewed Mar 15, 2024

View reviewed changes

core/blockchain.go Outdated Show resolved Hide resolved

zzzckck reviewed Mar 18, 2024

View reviewed changes

core/rawdb/freezer.go Show resolved Hide resolved

zzzckck previously approved these changes Mar 18, 2024

View reviewed changes

buddh0 commented Mar 19, 2024

View reviewed changes

internal/ethapi/api.go Outdated Show resolved Hide resolved

buddh0 dismissed zzzckck’s stale review via f6e66b0 March 19, 2024 06:56

buddh0 force-pushed the blobtx branch from ddc4f9f to f6e66b0 Compare March 19, 2024 06:56

buddh0 commented Mar 19, 2024

View reviewed changes

consensus/misc/eip4844/eip4844.go Outdated Show resolved Hide resolved

galaio and others added 13 commits March 21, 2024 10:07

ci: temp enable blobtx branch ci run;

286bbb8

Switch ON blobpool & ensure Cancun hardfork can occur (#2223)

595efc3

pool: switch ON blobpool+no reannotx

blobTx: mining + brodcasting (#2253)

49e78bb

blobtx mining pass (#2282)

8063efd

execution: add blob gas fee reward to system;

59a6552

syncing: support blob syncing & DA checking;

7afc260

ci: fix some failed UTs; sync: add more UTs for blob syncing;

naming: rename blobs to sidecars;

832e1fc

core: build fix (#2294)

e5d81b8

fix the semantics of WithXXX (#2293)

24b6fc7

zzzckck and others added 7 commits March 21, 2024 10:08

config: reduce sidecar cache to 1024 and rename (#2297)

dd6550d

fix: Withdrawals turn into empty from nil when BlockBody has Sidecars (…

cb56d54

…#2301)

internal/api_test: add test case for eth_getBlobSidecars && eth_getBl…

7b94187

…obSidecarByTxHash (#2300)

consensus/misc: rollback CalcBlobFee (#2306)

4f7c26c

flags: add new flags to override blobs' params;

da48fc8

freezer: fix blob ancient save error;

6552451

fix: fix som failed UTs;

420147c

buddh0 force-pushed the blobtx branch from cf9a04b to 420147c Compare March 21, 2024 02:14

fix: fix some validation issues & ancient reset; (#2316)

352bfd2

* fix: fix some validation issues & ancient reset; * fix: fix some UTs fails; * fix: fix some UTs fails;

blobsidecar: add new sidecar struct with metadata; (#2315)

2313e2c

* blobsidecar: add new sidecar struct with metadata; * blobfee: add UT to check blob fee reward; * fix: fix some UTs fails & comments;

NathanBSC reviewed Mar 22, 2024

View reviewed changes

core/rawdb/chain_freezer.go Outdated Show resolved Hide resolved

buddh0 added 2 commits March 22, 2024 13:42

core/rawdb: optimize write block with sidecars (#2318)

7fc9e28

* core: more check for validity of sidecars core/rawdb: optimize write block with sidecars core/rawdb: rollback interface freezeRange * core: fix TestIsDataAvailable

mev: add TxIndex for mev bid (#2325)

8e6835b

rollback interface of NewFreezer remove ci for blobtx

buddh0 marked this pull request as ready for review March 22, 2024 07:03

buddh0 and others added 4 commits March 22, 2024 17:16

remove useless Config() (#2326)

96605e4

fix WithSidecars (#2327)

0800afd

fix: fix mined block sidecar issue; (#2328)

a85b134

fix WithSidecars (#2329)

5560375

emailtovamos approved these changes Mar 22, 2024

View reviewed changes

zzzckck approved these changes Mar 22, 2024

View reviewed changes

zzzckck merged commit 38db9bf into develop Mar 22, 2024

This was referenced Apr 2, 2024

release: prepare for release v1.4.4-beta #2365

Merged

Draft release v1.4.4-beta #2366

Merged

4844: All changes #1798

Closed

zzzckck deleted the blobtx branch August 22, 2024 03:05

txhsl mentioned this pull request Oct 20, 2025

Persist and prune blob data correctly bane-labs/go-ethereum#520

Closed

Conversation

buddh0 commented Mar 13, 2024 • edited by zzzckck Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Rationale

Example

Changes

Uh oh!

Uh oh!

NathanBSC commented Mar 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buddh0 commented Mar 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zzzckck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NathanBSC commented Mar 21, 2024

Uh oh!

Uh oh!

buddh0 commented Mar 22, 2024

Uh oh!

buddh0 commented Mar 22, 2024

Uh oh!

zzzckck left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

buddh0 commented Mar 13, 2024 •

edited by zzzckck

Loading