Skip to content

cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme#2241

Merged
zzzckck merged 3 commits intobnb-chain:developfrom
sysvm:fix-defaultpbss
Mar 19, 2024
Merged

cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme#2241
zzzckck merged 3 commits intobnb-chain:developfrom
sysvm:fix-defaultpbss

Conversation

@sysvm
Copy link
Copy Markdown
Contributor

@sysvm sysvm commented Feb 28, 2024

Description

This PR flips the default state-scheme from hash to path, though it also adds a fallback for archive mode which force sets hash mode.

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • N/A

@sysvm sysvm added the r4r ready for review label Feb 28, 2024
zzzckck
zzzckck previously approved these changes Feb 28, 2024
Copy link
Copy Markdown
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RenRick
RenRick previously approved these changes Feb 28, 2024
Copy link
Copy Markdown

@RenRick RenRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fynnss
fynnss previously approved these changes Feb 28, 2024
@sysvm sysvm dismissed stale reviews from fynnss, RenRick, and zzzckck via f7e6956 February 28, 2024 07:51
@sysvm sysvm force-pushed the fix-defaultpbss branch 5 times, most recently from 5b59c0c to 362ce7c Compare February 28, 2024 09:40
@sysvm sysvm changed the title core: set path mode as default [WIP]core: set path mode as default Feb 28, 2024
@sysvm sysvm added wip work in process and removed r4r ready for review labels Feb 28, 2024
@sysvm sysvm force-pushed the fix-defaultpbss branch 2 times, most recently from 443b140 to f6b276d Compare February 28, 2024 10:45
* cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme

* graphql: run tests in hash mode as the chain maker needs it
@sysvm sysvm force-pushed the fix-defaultpbss branch from f6b276d to 54682c2 Compare March 14, 2024 08:39
@sysvm sysvm changed the title [WIP]core: set path mode as default cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme Mar 14, 2024
@sysvm sysvm added r4r ready for review and removed wip work in process labels Mar 15, 2024
@sysvm sysvm force-pushed the fix-defaultpbss branch 2 times, most recently from 4ab747f to fe59497 Compare March 15, 2024 11:44
zzzckck
zzzckck previously approved these changes Mar 18, 2024
@sysvm sysvm force-pushed the fix-defaultpbss branch 7 times, most recently from c4a2a3f to 26fc35f Compare March 19, 2024 02:28
@sysvm sysvm force-pushed the fix-defaultpbss branch from 26fc35f to a9ae645 Compare March 19, 2024 06:53
Copy link
Copy Markdown

@RenRick RenRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 10ae179 into bnb-chain:develop Mar 19, 2024
@sysvm sysvm deleted the fix-defaultpbss branch March 19, 2024 07:38
@Pjrich1313 Pjrich1313 mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r4r ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants