chore: render system bytecode by go:embed#2201
Merged
zzzckck merged 4 commits intobnb-chain:developfrom Apr 15, 2024
Merged
Conversation
08a09f7 to
ae5d08b
Compare
Collaborator
|
could include this PR after #2200 |
ae5d08b to
7e6ae62
Compare
Contributor
Author
|
The code was generated by this tool -> https://github.com/j75689/bsc-bytecode-extraction-tool |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zzzckck
reviewed
Apr 12, 2024
Collaborator
zzzckck
left a comment
There was a problem hiding this comment.
the byte code of mainnet is ok.
Will run full sync for testnet/mainnet and approve this PR sync passed, could take 2 weeks.
buddh0
approved these changes
Apr 12, 2024
Contributor
|
just ensure that hash of all codes not change after this PR |
zzzckck
approved these changes
Apr 12, 2024
zzzckck
approved these changes
Apr 15, 2024
This was referenced Apr 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
render system bytecode by
go:embedno impact on the system.
Rationale
As the system is upgraded, more and more
upgrade.gofiles are expanding, making it difficult to open and review the code.Use
go:embedinstead to render bytecode into the binary during compilation, which will reduce the difficulty of code maintenance in the future.Example
n/a
Changes
Notable changes: