what about VerifyNodes and TrustedNodesare we ok we are not connecting to those?

what about VerifyNodes and TrustedNodesare we ok we are not connecting to those?

I think we can include VerifyNodes, since the node is going to connect with the VerifyNodes when started right away, exactly the same as StaticNodes. For TrustedNodes, I don't think it's necessary because the scenario here targets NoDial = true, so TrustedNodes won't be connected anyways.

I think your needs should be solved using --nodiscover=true instead of modifying NoDial

[Node.P2P]
NoDiscovery = true

--nodiscover                   (default: false)
      Disables the peer discovery mechanism (manual peer addition)

However, your changes can indeed meet your needs, but I think nodiscover is more suitable for your needs. It can manually manage, add and delete

I think your needs should be solved using --nodiscover=true instead of modifying NoDial

[Node.P2P]
NoDiscovery = true

--nodiscover                   (default: false)
      Disables the peer discovery mechanism (manual peer addition)

However, your changes can indeed meet your needs, but I think nodiscover is more suitable for your needs. It can manually manage, add and delete

Not exactly. NoDiscovery disables the UDP port, which means that other nodes cannot discover our node at all. With this PR, enabling NoDial and StaticNodes would still allow other peers to discover and connect to our node, but our node won't be the one initiating the connection request (i.e. dialing), except for the static nodes.