eth/fetcher: allow underpriced transactions in after timeout (#28097)#2140
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jan 8, 2024
Merged
eth/fetcher: allow underpriced transactions in after timeout (#28097)#2140zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck merged 1 commit intobnb-chain:developfrom
Conversation
This PR will allow a previously underpriced transaction back in after a timeout of 5 minutes. This will block most transaction spam but allow for transactions to be re-broadcasted on networks with less transaction flow. --------- Co-authored-by: Felix Lange <fjl@twurst.com> # Conflicts: # eth/fetcher/tx_fetcher.go
zzzckck
approved these changes
Jan 8, 2024
emailtovamos
approved these changes
Jan 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherrypicks a PR from the Geth upstream. The original description is as follows:
"This PR will allow a previously underpriced transaction back in after a timeout of 5 minutes. This will block most transaction spam but allow for transactions to be re-broadcasted on networks with less transaction flow."
Rationale
Resolves #2084
We have some users saying that underpriced transactions were not able to be broadcast at all. This code change should help resolve that.
Credits
Special thanks to @terianil for sharing the info 😊