[WIP]cmd, core: resolve scheme from a read-write database#2135
Closed
sysvm wants to merge 7 commits intobnb-chain:developfrom
Closed
[WIP]cmd, core: resolve scheme from a read-write database#2135sysvm wants to merge 7 commits intobnb-chain:developfrom
sysvm wants to merge 7 commits intobnb-chain:developfrom
Conversation
ef0ac94 to
4da7fbd
Compare
7a5b18c to
27c865b
Compare
6f45edd to
2faa0ee
Compare
83ed03c to
54a247e
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
a6619c6 to
5ff3bda
Compare
5ff3bda to
09cb150
Compare
aac2695 to
7cf9a3b
Compare
ae3184d to
3d57011
Compare
3d57011 to
7efee69
Compare
fynnss
reviewed
Jan 10, 2024
zzzckck
reviewed
Jan 11, 2024
Contributor
|
some PRs are from go-ethereum |
Collaborator
|
LGTM, would approve once updated to keep the origin commit record. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request solves four pull requests: #2110, #2131, #2141, #2146
This issue can occur when unclean shutdown happens and freezer tables need to be repair. In database read-only mode, the freezer will only be validated but not repair and terminates the node abnormally.
This pull request moves the scheme check into the Ethereum constructor where the read-write database is already initialized. This approach can avoid opening read-only database in very early stage, to prevent this error totally.
Current geth doesn't deal with chain freezer dir in a good way. Therefore, this pr refactors
resolveChainFreezerDirto fix in pruned and non-pruned mode.Rationale
These will influence how should users use
pruenancientmode that block data could be replaced in which.Example
N/A
Changes
Notable changes: