cmd/geth: tidy flags for geth command#2109
Merged
zzzckck merged 2 commits intobnb-chain:developfrom Dec 27, 2023
buddh0:tidy_geth_flags
Merged
cmd/geth: tidy flags for geth command#2109zzzckck merged 2 commits intobnb-chain:developfrom buddh0:tidy_geth_flags
zzzckck merged 2 commits intobnb-chain:developfrom
buddh0:tidy_geth_flags
Conversation
galaio
reviewed
Dec 26, 2023
galaio
approved these changes
Dec 26, 2023
zzzckck
approved these changes
Dec 27, 2023
This was referenced Jan 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmd/geth: tidy flags for geth command
Rationale
some flags place wrong category or not support by bsc client this PR is to tidy them,
they are misleading when people use
geth --helpfor helpconfigFileFlag,
TxPoolReannounceTimeFlag,
logRotateFlag, following go-ethereum
MinerNewPayloadTimeout
AuthListenFlag
AuthPortFlag
AuthVirtualHostsFlag
JWTSecretFlag
put it into FastFinalityCategory is wrong, MinerCategory is not a perfect but a better way
Example
add an example CLI or API response...
Changes
Notable changes: