Skip to content

cmd/geth: tidy flags for geth command#2109

Merged
zzzckck merged 2 commits intobnb-chain:developfrom
buddh0:tidy_geth_flags
Dec 27, 2023
Merged

cmd/geth: tidy flags for geth command#2109
zzzckck merged 2 commits intobnb-chain:developfrom
buddh0:tidy_geth_flags

Conversation

@buddh0
Copy link
Copy Markdown
Contributor

@buddh0 buddh0 commented Dec 26, 2023

Description

cmd/geth: tidy flags for geth command

Rationale

some flags place wrong category or not support by bsc client this PR is to tidy them,
they are misleading when people use geth --help for help

  1. add Category for
    configFileFlag,
    TxPoolReannounceTimeFlag,
    logRotateFlag, following go-ethereum
  2. new comment 5 flags for geth, they are not support by bsc client
    MinerNewPayloadTimeout
    AuthListenFlag
    AuthPortFlag
    AuthVirtualHostsFlag
    JWTSecretFlag
  3. change Category for EnableDoubleSignMonitorFlag
    put it into FastFinalityCategory is wrong, MinerCategory is not a perfect but a better way
  4. rename HistoryCategory to BlockHistoryCategory, correspond to StateCategory

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 changed the base branch from master to develop December 26, 2023 08:41
@buddh0 buddh0 changed the title Tidy geth flags cmd/geth: tidy flags for geth command Dec 26, 2023
@buddh0 buddh0 added the r4r ready for review label Dec 27, 2023
@zzzckck zzzckck merged commit 267c5c0 into bnb-chain:develop Dec 27, 2023
@buddh0 buddh0 deleted the tidy_geth_flags branch January 19, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r4r ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants