params: use rialto to test builtin network logic#2106
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Dec 28, 2023
buddh0:use_riolta_2_hard_fork_test
Merged
params: use rialto to test builtin network logic#2106buddh0 merged 1 commit intobnb-chain:developfrom buddh0:use_riolta_2_hard_fork_test
buddh0 merged 1 commit intobnb-chain:developfrom
buddh0:use_riolta_2_hard_fork_test
Conversation
Contributor
Author
|
how to use rialto to do local test, can refer to https://github.com/bnb-chain/node-deploy/pull/26/files |
zzzckck
approved these changes
Dec 27, 2023
zlacfzy
approved these changes
Dec 28, 2023
This was referenced Jan 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
params: use rialto to test builtin network logic
Rationale
there are three builtin network, mainnet, chapel, rialto
if we only use non-builtin network to test, some bugs may can't be found,
that is the reason of releasing v1.3.6 and v1.3.7
rialto with chainid 1417 is a deprecated testnet, useless now, but we can use it to test builtin network logics.
for now, during testing, we need to
RialtoGenesisHashthen recompile client. It's very not convinient, this PR want to address them.
In this PR,
rialtohashcan be used to pass real genesis hash of your local testnetoverride.shanghaiandoverride.keplerare used to override the hardcoded harfork times,following exsited
override.cancunandoverride.verkle, they just used to test, not onlineby the way, old upgrade codes for rialto network are useless, so delete them
Example
add an example CLI or API response...
Changes
Notable changes: