Merged
Conversation
534a8f1 to
56b5105
Compare
* cmd, les, tests: remove light client code This commit removes the light client (LES) code. Since the merge the light client has been broken and it is hard to maintain it alongside the normal client. We decided it would be best to remove it for now and maybe rework and reintroduce it in the future. * cmd, eth: remove some more mentions of light mode * cmd: re-add flags and mark as deprecated * cmd: warn the user about deprecated flags * eth: better error message
This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
This changes removes the package 'light', which is currently unused.
weiihann
approved these changes
Jan 3, 2024
This was referenced Jan 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BSC Client Update: Removal of LES and Light Client
Description
This update is dedicated to removing the LES (Light Ethereum Subprotocol) and the light client functionality from our BSC client codebase. The primary goal is to streamline the code, enhance performance, and align with our strategic direction towards supporting more robust, full-node operations on the BNB Chain.
Rationale
The removal of LES and the light client from the BSC codebase is a strategic decision influenced by their diminishing utility, performance considerations, and maintenance demands. Originally designed for light clients on BSC, LES has observed a decline in usage, particularly with the growing trend of full nodes within the BSC ecosystem. Maintaining this feature has been increasingly resource-intensive. Eliminating it allows for a more focused approach towards optimizing the performance and security of full nodes. This move is also in line with the broader trend within the BNB Chain community towards stronger and more secure network operations.
Example
CLI/API response before changes:
CLI/API response after changes:
Changes
Notable changes: