Skip to content

core: LoadChainConfig return the predefined config for built-in networks firstly#2078

Merged
buddh0 merged 4 commits intobnb-chain:developfrom
buddh0:LoadChainConfig_builtin_net
Dec 18, 2023
Merged

core: LoadChainConfig return the predefined config for built-in networks firstly#2078
buddh0 merged 4 commits intobnb-chain:developfrom
buddh0:LoadChainConfig_builtin_net

Conversation

@buddh0
Copy link
Copy Markdown
Contributor

@buddh0 buddh0 commented Dec 18, 2023

Description

core: LoadChainConfig return the predefined config for built-in networks firstly

Rationale

  1. for the built-in networks, the predefined config is the standard
    and they should not be configured in the config.toml
    so return the predefined config
  2. furtherly, for local test or private network, can use geth init to upgrade the chain config,
    so we just stop supporting read chain config from the config.toml.
    by doing this, logic about chain config can be simplified.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

zzzckck
zzzckck previously approved these changes Dec 18, 2023
Copy link
Copy Markdown
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

galaio
galaio previously approved these changes Dec 18, 2023
zzzckck
zzzckck previously approved these changes Dec 18, 2023
@buddh0 buddh0 dismissed stale reviews from zzzckck and galaio via 849d5a2 December 18, 2023 08:44
@buddh0 buddh0 merged commit e44de3a into bnb-chain:develop Dec 18, 2023
@NathanBSC
Copy link
Copy Markdown
Contributor

#2071

@buddh0 buddh0 deleted the LoadChainConfig_builtin_net branch December 22, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants