log: support to disable log rotate by hours#2063
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Dec 14, 2023
buddh0:can_disable_log_rorate_by_hours
Merged
log: support to disable log rotate by hours#2063zzzckck merged 1 commit intobnb-chain:developfrom buddh0:can_disable_log_rorate_by_hours
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:can_disable_log_rorate_by_hours
Conversation
bnb-alexlucaci
approved these changes
Dec 13, 2023
zzzckck
approved these changes
Dec 14, 2023
This was referenced Dec 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
log: support to disable log rotate by hours
Rationale
#114 suggest that
to support type 1, only rotate by size,
we should have the ablitiy to disable the default one hour rotation, this PR add this support
by setting
RotateHours=0in config.toml, rotate by hours is disabledExample
add an example CLI or API response...
Changes
Notable changes: