Skip to content

Set default hardfork times#2058

Merged
buddh0 merged 2 commits intobnb-chain:developfrom
buddh0:set_default_hardfork_times
Dec 13, 2023
Merged

Set default hardfork times#2058
buddh0 merged 2 commits intobnb-chain:developfrom
buddh0:set_default_hardfork_times

Conversation

@buddh0
Copy link
Copy Markdown
Contributor

@buddh0 buddh0 commented Dec 12, 2023

Description

Set default hardfork times

Rationale

hardfork transit to time based from shanghai

we should set default values for time based hardforks as we have done for block based hardforks.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Mister-EA
Mister-EA previously approved these changes Dec 12, 2023
@buddh0
Copy link
Copy Markdown
Contributor Author

buddh0 commented Dec 13, 2023

have test locally,steps:
image

  1. set a cluster with a genesis.json, but ShanghaiTime and KeplerTime not set
  2. modify ChapelGenesisHash of bsc client to genesishash of the above cluster
  3. restart bsc, and found that ShanghaiTime and KeplerTime have been set successfully

@buddh0 buddh0 merged commit 1ebf2a4 into bnb-chain:develop Dec 13, 2023
@buddh0 buddh0 deleted the set_default_hardfork_times branch December 22, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants