core/vote: wait some blocks beforing voting since mining begin#2051
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Dec 13, 2023
buddh0:wait_blocks_voting_since_mining
Merged
core/vote: wait some blocks beforing voting since mining begin#2051buddh0 merged 1 commit intobnb-chain:developfrom buddh0:wait_blocks_voting_since_mining
buddh0 merged 1 commit intobnb-chain:developfrom
buddh0:wait_blocks_voting_since_mining
Conversation
zzzckck
approved these changes
Dec 11, 2023
unclezoro
approved these changes
Dec 13, 2023
This was referenced Dec 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/vote: wait some blocks beforing voting since mining begin
Rationale
many validators have backup machines
when they shutdown their running node and start the validator on the backup machine,
the new started node may vote for blocks in the same height with the down node voted for.
so, this PR let node wait some blocks beforing voting since it's mining begin
Example
add an example CLI or API response...
Changes
Notable changes: