all: pull snap sync PRs from upstream v1.13.5#2035
Merged
zzzckck merged 8 commits intobnb-chain:developfrom Dec 19, 2023
Merged
all: pull snap sync PRs from upstream v1.13.5#2035zzzckck merged 8 commits intobnb-chain:developfrom
zzzckck merged 8 commits intobnb-chain:developfrom
Conversation
9890991 to
80c8e5d
Compare
…198) This PR adds more error message for debugging purpose.
80c8e5d to
3a5ec36
Compare
emailtovamos
approved these changes
Dec 10, 2023
Contributor
emailtovamos
left a comment
There was a problem hiding this comment.
I did a basic check on the code & it looks good to me based on my limited understanding of sync/snapshot/trie package.
However someone who has worked in these directly in the past should also have a look.
buddh0
approved these changes
Dec 14, 2023
Contributor
|
I reviewed the origin 7 patches one by one |
This was referenced Dec 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherrypicks PRs related to snap sync from the Geth upstream. There were some bugs related to snap sync + PBSS which are fixed in these PRs.
Upstream PRs
Sync Result
Machine:
x64, 4TB, 8Core, 30GB, ssdStart up command:
Time taken to sync to the latest block: 1 day and 10 hours
Time taken to download chain data: 1 day and 3 hours 12 minutes
Time taken to download state data: 1 day and 6 hours 36 minutes
Time taken for state healing: 3 hours 26 minutes