feat: add generate-proof to geth cmd#2028
Merged
pythonberg1997 merged 2 commits intobnb-chain:bc-fusionfrom Dec 5, 2023
Merged
feat: add generate-proof to geth cmd#2028pythonberg1997 merged 2 commits intobnb-chain:bc-fusionfrom
generate-proof to geth cmd#2028pythonberg1997 merged 2 commits intobnb-chain:bc-fusionfrom
Conversation
unclezoro
reviewed
Dec 5, 2023
| PublicKey: pubkeyBz, | ||
| SigningRoot: msgHash, | ||
| } | ||
| sig, err := km.Sign(context.Background(), req) |
Contributor
There was a problem hiding this comment.
Have we verified that the signature that generate here can be verified by the stakingHub contract?
unclezoro
approved these changes
Dec 5, 2023
buddh0
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add cmd
generate-proofto geth.Rationale
After feynman upgrade, anyone who wants to create a validator should provide a bls proof of his vote address. This cmd is to facilitate that.
Changes
Notable changes:
generate-proofto geth