core/systemcontracts: include BEP-319 on kepler hardfork#1973
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Nov 22, 2023
buddh0:kepler_hardfork
Merged
core/systemcontracts: include BEP-319 on kepler hardfork#1973buddh0 merged 1 commit intobnb-chain:developfrom buddh0:kepler_hardfork
buddh0 merged 1 commit intobnb-chain:developfrom
buddh0:kepler_hardfork
Conversation
| // Handle upgrade build-in system contract code | ||
| systemcontracts.UpgradeBuildInSystemContract(p.config, block.Number(), statedb) | ||
| lastBlock := p.bc.GetBlockByHash(block.ParentHash()) | ||
| if lastBlock == nil { |
Contributor
There was a problem hiding this comment.
Just thinking about edge case here, there is no need to check if the block itself is nil similar to how we are checking its parent to be nil?
Contributor
Author
There was a problem hiding this comment.
the parent may be pruned.
Contributor
There was a problem hiding this comment.
Yes but the block itself is always non-nil in this case right?
Contributor
Author
There was a problem hiding this comment.
yes. there is only two places call the func Process ,except in test cases
and they all check block to be non-nill before calling Process
emailtovamos
approved these changes
Nov 22, 2023
bnb-alexlucaci
approved these changes
Nov 22, 2023
This was referenced Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/systemcontracts: include BEP-319 on kepler hardfork
Rationale
two contents in kepler hard fork
related code is implemented in bsc-genesis-contract
Example
add an example CLI or API response...
Changes
Notable changes: