Skip to content

parlia: reject header with WithdrawalsHash before shanghai fork#1884

Merged
buddh0 merged 3 commits intobnb-chain:developfrom
node-real:reject_WithdrawalsHash_before_shanghai
Sep 21, 2023
Merged

parlia: reject header with WithdrawalsHash before shanghai fork#1884
buddh0 merged 3 commits intobnb-chain:developfrom
node-real:reject_WithdrawalsHash_before_shanghai

Conversation

@NathanBSC
Copy link
Copy Markdown
Contributor

@NathanBSC NathanBSC commented Sep 20, 2023

Description

consensus/parlia: reject header with WithdrawalsHash before shanghai fork

Rationale

WithdrawalsHash is not need by bsc, ensure it to be nil

Example

add an example CLI or API response...

Changes

Notable changes:

  • add owner of some TODO
  • show flag miner.delayleftover in help doc and shadow flag miner.newpayload-timeout,
    disable warn log about newpayloadTimeout, because it's useless for bsc
  • change way of dumping chainConfig
  • delete useless param chainconfig for VotePool and VoteManager
  • fix TestOptionMaxPeersPerIP failure of goroutine order

keep consistent with go-ethereum, miss them when big merge:

  • use LoadChainConfig to replace SetupGenesisBlockWithOverride, the later func has been called in NewBlockChain
  • rename Synchronise to LegacySync

@NathanBSC NathanBSC force-pushed the reject_WithdrawalsHash_before_shanghai branch from 8537d4e to ba32957 Compare September 20, 2023 11:44
@NathanBSC NathanBSC changed the title consensus/parlia: reject header with WithdrawalsHash before shanghai parlia: reject header with WithdrawalsHash before shanghai fork Sep 20, 2023
@NathanBSC NathanBSC force-pushed the reject_WithdrawalsHash_before_shanghai branch from 969ef72 to 95d19ed Compare September 20, 2023 13:48
brilliant-lx
brilliant-lx previously approved these changes Sep 21, 2023
@buddh0 buddh0 merged commit 52e2cb8 into bnb-chain:develop Sep 21, 2023
@NathanBSC NathanBSC deleted the reject_WithdrawalsHash_before_shanghai branch September 21, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants