Skip to content

lint: fix all golang lint after big merge#1861

Merged
brilliant-lx merged 1 commit intobig_merge_v1.10.16_v1.12.2from
big_merge_v1.10.16_v1.12.2_fix_lintCI
Sep 8, 2023
Merged

lint: fix all golang lint after big merge#1861
brilliant-lx merged 1 commit intobig_merge_v1.10.16_v1.12.2from
big_merge_v1.10.16_v1.12.2_fix_lintCI

Conversation

@NathanBSC
Copy link
Copy Markdown
Contributor

@NathanBSC NathanBSC commented Sep 8, 2023

Description

lint: fix all golang lint after big merge

by the way, GetDiffAccountsWithScope was deleted by mistake, thus complaint needToReplay no used
so bring it back

Rationale

tell us why we need these changes...

Example

no complaint by the following command now:

golangci-lint run --out-format=github-actions --path-prefix=./ --timeout=99m --config ./.golangci.yml 

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@brilliant-lx brilliant-lx merged commit 0f622f3 into big_merge_v1.10.16_v1.12.2 Sep 8, 2023
@buddh0 buddh0 deleted the big_merge_v1.10.16_v1.12.2_fix_lintCI branch September 14, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants