core/state: no need to prune block if the same #1332
Merged
zzzckck merged 3 commits intobnb-chain:developfrom Jan 22, 2024
Merged
core/state: no need to prune block if the same #1332zzzckck merged 3 commits intobnb-chain:developfrom
zzzckck merged 3 commits intobnb-chain:developfrom
Conversation
0fefa12 to
282e7db
Compare
Contributor
Author
|
@brilliant-lx and please take a look at this one |
brilliant-lx
previously approved these changes
May 6, 2023
Contributor
got it, thx |
eafdf1c to
aaa29e7
Compare
joey0612
previously approved these changes
Jan 9, 2024
The merge-base changed after approval.
Contributor
|
LGTM, it checks the |
The merge-base changed after approval.
Collaborator
|
@jsvisa could you rebase your branch to latest develop? |
Collaborator
|
@jsvisa could you rebase your branch? or we may create a separate PR to include your change. |
Signed-off-by: Delweng <delweng@gmail.com>
This reverts commit 1bbd4b8. Signed-off-by: Delweng <delweng@gmail.com>
Signed-off-by: Delweng <delweng@gmail.com>
aaa29e7 to
d0539a4
Compare
Contributor
Author
|
@zzzckck sorry for the late reply, finished rebasing. |
joey0612
approved these changes
Jan 22, 2024
zzzckck
approved these changes
Jan 22, 2024
This was referenced Jan 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't need to run
prune-blockif specified reserve blocks are the same to items in ancientdb