[R4R]fix: verify node is not treated as verify node#1024
Merged
unclezoro merged 1 commit intobnb-chain:developfrom Jul 28, 2022
Merged
[R4R]fix: verify node is not treated as verify node#1024unclezoro merged 1 commit intobnb-chain:developfrom
unclezoro merged 1 commit intobnb-chain:developfrom
Conversation
forcodedancing
approved these changes
Jul 28, 2022
j75689
approved these changes
Jul 28, 2022
This was referenced Jul 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the fast node, verify node is a special setting that can do remove state root verification.
The development branch does have bugs in mark verify nodes. This PR aims to fix the bug.
Rationale
Both
dialDestandnhere is pointers, we shall just compare whether the ID equals.Example
After the patch, fast node can work smoothly in
fullandinsecuremode.Changes
No