[R4R] fix: Incorrect merkle root issue when enabling pipecommit with miner#1011
Merged
unclezoro merged 2 commits intobnb-chain:developfrom Jul 22, 2022
Merged
[R4R] fix: Incorrect merkle root issue when enabling pipecommit with miner#1011unclezoro merged 2 commits intobnb-chain:developfrom
unclezoro merged 2 commits intobnb-chain:developfrom
Conversation
realuncle
approved these changes
Jul 22, 2022
unclezoro
approved these changes
Jul 22, 2022
Contributor
|
Cool. So we need to put the |
forcodedancing
approved these changes
Jul 22, 2022
yutianwu
approved these changes
Jul 22, 2022
This was referenced Jul 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pipecommitwith miner.
2. Account root hash is incorrect when doing `statedb.CorrectAccountsRoot `.Rationale
parliaconsensus will call the system contract inFinalizeAndAssemble, and change the state of the world. But before that, thestatedbis copied, but this copiedstatedbwill not be used when writing blocks, resulting in incorrect writing of the world state.account rootis an empty hash, the correctemptyhashvalue is not assigned.Example
N/A
Changes
Notable changes:
statedbafterFinalizeAndAssemble