Skip to content

[R4R]fix: resolve the concurrent cache read and write issue for fast node#1009

Merged
unclezoro merged 2 commits intodevelopfrom
fix_cache_concurrency
Jul 22, 2022
Merged

[R4R]fix: resolve the concurrent cache read and write issue for fast node#1009
unclezoro merged 2 commits intodevelopfrom
fix_cache_concurrency

Conversation

@kyrie-yl
Copy link
Copy Markdown
Contributor

Signed-off-by: cryyl yl.on.the.way@gmail.com

Description

When fast node insert a block, it will judge whether the 11 ahead of current block has been verified. While, if a block is an empty block, it must be verified. So if the 11 ahead block is an empty block, the AncestorVerified function will return true.

Rationale

Example

Changes

Notable changes:

  • In the AncestorVerified function, if the 11 ahead of current block is an empty block, return true.

Signed-off-by: cryyl <yl.on.the.way@gmail.com>
@unclezoro unclezoro changed the title fix cache read and write concurrency issue of empty block [R4R]fix: resolve the concurrent cache read and write issue for fast node Jul 21, 2022
unclezoro
unclezoro previously approved these changes Jul 21, 2022
@unclezoro
Copy link
Copy Markdown
Contributor

LGTM

@unclezoro unclezoro force-pushed the fix_cache_concurrency branch from 8288715 to 287677a Compare July 22, 2022 06:39
@unclezoro unclezoro merged commit 015c527 into develop Jul 22, 2022
This was referenced Jul 28, 2022
@unclezoro unclezoro deleted the fix_cache_concurrency branch September 2, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants