[R4R] fix: missing contract upgrades and incorrect behavior when miners enable pipecommit#1007
Merged
unclezoro merged 1 commit intobnb-chain:developfrom Jul 20, 2022
Merged
Conversation
forcodedancing
previously approved these changes
Jul 20, 2022
unclezoro
previously approved these changes
Jul 20, 2022
67dbd12
unclezoro
approved these changes
Jul 20, 2022
forcodedancing
approved these changes
Jul 20, 2022
This was referenced Jul 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bsc/miner/worker.go
Line 966 in de4abf9
statebwhen miner enablespipecommit.Rationale
commit, a new*environmentis copied to work, but whenpipecommitis enabled,CorrectAccountsRootshould be called to correct the root hash of the accounts in the snapshot, which results in only the copied ones be updated, and the continuously runningstatedbis not properly updated.Example
N/A
Changes
Notable changes: