Skip to content

Feature: add/remove EVNNodeIDs from config.toml #3071

@zzzckck

Description

@zzzckck

Rationale

It is not that convenient for node operators to removeNodeID if they need to construct a transaction to call the SystemContract of method: removeNodeIDs()
It would be better if we can provide a tool or make it configurable.

Implementation

To support it in config.toml, from user's perspective, it could be like:

[Node.P2P]
EVNNodeIDsToRemove = ["nodeid1", "nodeid2"]
EVNNodeIDsToAdd = ["nodeid1", "nodeid3", "nodeid4"]

with valid validator key, it will remove "nodeid2", then add "nodeid3" and "nodeid4"

Notice:

  • perform remove first, then perform add
  • deduplicate, if nodeid is both included in EVNNodeIDsToRemove and EVNNodeIDsToAdd
  • EVNNodeIDsToRemove = [], will not remove any nodeid
  • EVNNodeIDsToRemove = ["0x0000000000000000000000000000000000000000000000000000000000000000"], will remove all nodeid
  • Would be better if we can also have a tool to remove/add nodeids

Some Reference:
https://github.com/bnb-chain/bsc/pull/3045/files#diff-93626ed7f697f5674903a96e7153e88a4f2d8596df186489fb0c26557eb80889R97
https://github.com/bnb-chain/bsc/pull/3070/files#diff-acee05032ef99ca2f9b7dd27429bc2659189fe9cd96fc8699a95f4c7f18728c5R92 (How about rename EVNNodeIdsWhitelist to EVNNodeIDsWhitelist)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions