BEP 7: Bring Non-fungible Tokens(NFTs) to Binance Chain and expand the use cases. by amazingandyyy · Pull Request #7 · bnb-chain/BEPs

amazingandyyy · 2019-05-23T06:25:43Z

With Non-fungible Tokens, we can expand the token use cases on Binance Chain to be:

Event Ticket
VIP Privilege Status
Collectibles Assets
more ...

Every token is transferrable, tradable, mintable, burnable and most important, non-fungible.

darren-liu · 2019-05-26T13:20:40Z

It reads to me majority of the BEP is the same as the BEP2. It will be more clear and usable to highlight the commons and differences from BEP2, which is more friendly to readers and tells details for implementation and usage.

…ew-proposal

BEP7.md

amazingandyyy · 2019-06-18T06:41:29Z

@darren-liu I change some contents in the past week, the biggest difference here

introduce the idea of collection which contains a symbol, e.g. NNB-B90, totalSupply, and a []NFT nft token array)
every NFT has it's own incremental id and metadata field which make this NFT highly compatible to other existing NFT tokens, e.g. ERC721, to make it easy to integrate with third-party services as @ProjectOpenSea and then smooth out integration on @trustwallet per @vikmeup's suggestion.

BEP7.md

okwme · 2019-07-20T00:16:14Z

@darren-liu I change some contents in the past week, the biggest difference here

introduce the idea of collection which contains a symbol, e.g. NNB-B90, totalSupply, and a []NFT nft token array)

every NFT has it's own incremental id and metadata field which make this NFT highly compatible to other existing NFT tokens, e.g. ERC721, to make it easy to integrate with third-party services as @ProjectOpenSea and then smooth out integration on @trustwallet per @vikmeup's suggestion.

i'm worried about the requirement of incremental id. In the spec you list ID as a string but incremental IDs make me think you imply to change to int. There are many projects which will need more fine grained control over their ID system. ERC-721 handles this well by allowing tokens to be queried by index while not requiring the token IDs to be incremental.

For example I have a game where I encode some item information into the ID itself, this is a convenient way for me to store information about the NFT without redundant storage costs.

Or another example might be NFTs that represent in-stock items that already have their own alphanumeric id system. It would be redundant to have multiple IDs per item and the app designer would prefer to use the same ID on both systems.

For this reason I'd suggest allowing IDs to be string but create an additional qeuerier that requests information about denomination and the index of the NFT. Furthermore this could be extended into a full pagination with an index and a limit to access multiple NFTs incrementally while still preserving choice of ID.

okwme · 2019-07-21T05:46:08Z

For reference here is a summary spec of the Cosmos-NFT Module:
https://hackmd.io/@okwme/cosmos-nft

BEP7.md

fedekunze · 2019-07-23T15:05:31Z

For reference here is a summary spec of the Cosmos-NFT Module:
https://hackmd.io/@okwme/cosmos-nft

Moved to cosmos/cosmos-sdk#4766

casmirconsensys

looks good now...

casmirconsensys

looks good now!

amazingandyyy · 2019-07-31T05:04:11Z

@casmirconsensys I can see one major thing is unclear is about the chianId, may need to have eng from binance come in and give their idea of cross-chain/IBC/cosmos...etc technical details on this.

okwme · 2019-07-31T07:59:46Z

Here's the technical diagram from the call today. This relates to lower level implementation but also brings up some of the Msg Types that a BEP-7 NFT might want to use:

NewCollectionMsg - For making new Collections (probably after paying a fee)
RemoveCollectionMsg - For removing Collections by some admin that might violate some TOS
ChangeExecutorMsg - Updating the execotor role for a collection
ChangeTotalSupplyMsg - Updating the totalSupply for a collection
FreezeCollectionMsg - Freezing transfers of a collection
UnfreezeCollectionMsg - Unfreezing transfers of a collection

amazingandyyy · 2019-07-31T08:00:28Z

Summary from zoom call with cosmos & binance team on 7/31 12pm:

cosmos will release BasicNFT keeper(including collection/nft) in a seperated modules repo, and hope binance can build another keeper layer(binance-specific keeper) on top of it
for metadata concern, tokenURI is only properties in the BasicNFT keeper
The scope of this PR(BEP7) is to propose of
a. define binance-specific keeper(more properties)
b. define binance-specific handler(more management)

HaoyangLiu · 2019-08-27T02:33:57Z

BEP7.md

+| **Field** | **Type** | **Description**                                                 |
+| :--------- | :-------- | :------------------------------------------------------------ |
+| Denom     | string   | The symbol of a collection - e.g. NNB-B90                       |
+| ID        | string   | The id of a token in the collection                             |


Do you think the freeze period is necessary? If there is no freeze period, the owners can freeze and unfreeze their assets at anytime, thus the freeze operation will have no limitation for owners.

Hmm I think this may be a layover from BEP2... Agree let's toss it if it's not relevant to BEP7

@casmirconsensys why, I think freeze is a good feature.

@HaoyangLiu Freeze period is a good suggestion, have any idea of what time unit it should be? (blocktime, block height...etc)

HaoyangLiu · 2019-08-27T02:44:33Z

BEP7.md

+| **Field**  | **Type**  | **Description**              |
+| :--------- | :-------- | :---------------------------- |
+| Denom      | string    | The symbol of the collection |
+| Amount     | int64     | The amount is positive and can have a maximum of 8 digits of decimal and is boosted by 1e8 in order to store as int64. |


Is it necessary to have decimals for non-fungible tokens?

hmm... unless its a composable ERC998 or an NFT like ERC1155 that can mint multiple ERC20 & NFT from the same type of contract if say for instance we needed to represent that in a Wallet perhaps maybe @coinfork from Enjin can chime in on how representation in a Wallet like Trust Wallet with Binance BEP2 could be a potential use case..? From what I understand some ERC1155 can have ERC20 like properties as well no? @coinfork

//ERC1155 Metadata JSON Schema
Assets made on the Enjin Platform may contain metadata that is based on the ERC721 Metadata JSON Schema. We are adding an optional formatting standard to this schema to increase efficiency for games that need to manage metadata for thousands of items.//

JSON Format
Example:

{
"name": "Asset Name",
"description": "Lorem ipsum...",
"image": "https://s3.amazonaws.com/your-bucket/images/{id}.png",
"properties": {
"simple_property": "example value",
"rich_property": {
"name": "Name",
"value": "123",
"display_value": "123 Example Value",
"class": "emphasis",
"css": {
"color": "#ffffff",
"font-weight": "bold",
"text-decoration": "underline"
}
},
"array_property": {
"name": "Name",
"value": [1, 2, 3, 4],
"class": "emphasis"
}
}
}

@HaoyangLiu yea, I am thinking just use uint

casmirconsensys

Looks ready to merge!

casmirconsensys

Is this requesting for approval from @amazingandyyy?

amazingandyyy · 2020-05-13T20:32:49Z

yes, @casmirconsensys it will be great if this can get merged and the community can move forward to help

casmirconsensys · 2020-05-13T22:29:01Z

@amazingandyyy Let's Do This!! Who else is on board to approve this thing? @okwme @zmanian

casmirconsensys · 2020-05-13T22:52:41Z

@casmirconsensys I can see one major thing is unclear is about the chianId, may need to have eng from binance come in and give their idea of cross-chain/IBC/cosmos...etc technical details on this.

What have we heard from Binance Eng about this so far? @amazingandyyy

okwme · 2020-05-14T09:19:21Z

confused why my comments are marked as "pending" still...

amazingandyyy

@okwme thanks for the screenshot, I updated it on line 150 accordingly.

For pending comments, you need to click the right top green button (finish your review)

casmirconsensys

Would be nice to have some XML-JSX-TSX Metadata Schemas added.

brilliant-lx · 2022-12-02T01:46:13Z

outdate, archive it.

Andy Chen added 5 commits May 22, 2019 22:51

create BEP6

cb77219

add BEP

15385ee

update BEP

ab68a8b

draft BEP

bf10ea9

add metadata fields

930051b

Andy Chen added 3 commits June 8, 2019 13:04

Merge branch 'master' of https://github.com/binance-chain/BEPs into n…

218ea0b

…ew-proposal

Update BEP7.md

45f4ef2

Update BEP7.md

a4c756d

amazingandyyy changed the title ~~BEP 7: Bring Non-fungible Tokens to Binance Chain and expand the use cases.~~ BEP 7: Bring Non-fungible Tokens(NFTs) to Binance Chain and expand the use cases. Jun 12, 2019

amazingandyyy and others added 4 commits June 17, 2019 03:26

Update BEP7.md

0e6c17e

add references to cosmos/cosmos-sdk

eb76c17

add collection, refactor NFT token

370300e

update Token Specification

59a18a5

amazingandyyy commented Jun 18, 2019

View reviewed changes

BEP7.md Outdated Show resolved Hide resolved

amazingandyyy commented Jun 18, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

amazingandyyy and others added 13 commits June 18, 2019 11:31

Update BEP7.md

8cbfa77

Update BEP7.md

5cd5173

Update BEP7.md

9171eab

Update BEP7.md

6a5a07d

add collection to token properties.

c5842da

add Mintable to collection

c064196

add difficulty suggestion to collection

febc80d

fix typo

d8714ce

Update BEP7.md

31e6be1

add 5.2.2 Increase total supply, update issue/freeze/unfreeze token

8617951

update properties

148c671

Update BEP7.md

2affb87

Update BEP7.md

6ad291a

casmirconsensys reviewed Jul 17, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

casmirconsensys approved these changes Jul 17, 2019

View reviewed changes

casmirconsensys reviewed Jul 17, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

casmirconsensys reviewed Jul 17, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

casmirconsensys reviewed Jul 17, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

okwme reviewed Jul 23, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

okwme reviewed Jul 23, 2019

View reviewed changes

BEP7.md Show resolved Hide resolved

casmirconsensys reviewed Jul 31, 2019

View reviewed changes

casmirconsensys approved these changes Jul 31, 2019

View reviewed changes

HaoyangLiu reviewed Aug 27, 2019

View reviewed changes

casmirconsensys reviewed May 10, 2020

View reviewed changes

casmirconsensys previously approved these changes May 10, 2020

View reviewed changes

Update BEP7.md

2797170

amazingandyyy dismissed casmirconsensys’s stale review via 2797170 May 17, 2020 02:48

amazingandyyy commented May 17, 2020

View reviewed changes

casmirconsensys approved these changes Jun 17, 2021

View reviewed changes

brilliant-lx closed this Dec 2, 2022

Conversation

amazingandyyy commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darren-liu commented May 26, 2019

Uh oh!

Uh oh!

Uh oh!

amazingandyyy commented Jun 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

okwme commented Jul 20, 2019

Uh oh!

okwme commented Jul 21, 2019

Uh oh!

Uh oh!

Uh oh!

fedekunze commented Jul 23, 2019

Uh oh!

casmirconsensys left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

casmirconsensys left a comment

Choose a reason for hiding this comment

Uh oh!

amazingandyyy commented Jul 31, 2019

Uh oh!

okwme commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amazingandyyy commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HaoyangLiu Aug 27, 2019

Choose a reason for hiding this comment

Uh oh!

casmirconsensys Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amazingandyyy Aug 27, 2019

Choose a reason for hiding this comment

Uh oh!

amazingandyyy Aug 27, 2019

Choose a reason for hiding this comment

Uh oh!

HaoyangLiu Aug 27, 2019

Choose a reason for hiding this comment

Uh oh!

casmirconsensys Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amazingandyyy Aug 27, 2019

Choose a reason for hiding this comment

Uh oh!

casmirconsensys left a comment

Choose a reason for hiding this comment

Uh oh!

casmirconsensys left a comment

Choose a reason for hiding this comment

Uh oh!

amazingandyyy commented May 13, 2020

Uh oh!

casmirconsensys commented May 13, 2020

Uh oh!

casmirconsensys commented May 13, 2020

Uh oh!

okwme commented May 14, 2020

Uh oh!

amazingandyyy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

casmirconsensys left a comment

amazingandyyy commented May 23, 2019 •

edited

Loading

amazingandyyy commented Jun 18, 2019 •

edited

Loading

casmirconsensys left a comment •

edited

Loading

okwme commented Jul 31, 2019 •

edited

Loading

amazingandyyy commented Jul 31, 2019 •

edited

Loading

casmirconsensys Aug 27, 2019 •

edited

Loading

casmirconsensys Aug 27, 2019 •

edited

Loading

amazingandyyy left a comment •

edited

Loading