BEP-226: Implement EIP-1559 with base fee of 0#226
Merged
brilliant-lx merged 2 commits intomasterfrom May 25, 2023
Merged
Conversation
Contributor
|
EIP-1559 would have dependency on others EIPs, like: |
brilliant-lx
approved these changes
May 25, 2023
This was referenced Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEP: 226 Title: Enable EIP-1559 with base fee of 0 Status: Pre-Draft Type: Standards Created: 2023-04-17BEP-226: Enable EIP-1559 with base fee of 0
1. Summary
This BEP introduces EIP-1559 headers and transactions to BSC but with base fee set to 0.
2. Motivation
To keep up to date with the latest developments in EVM blockchains it is important to keep the block and transaction structures up to date. New features (such as account abstraction) being introduced
to EVM chains already presuppose EIP-1559 type of block headers and transactions. Therefore, for compatibility reasons it is important that EIP-1559 constructs be enabled on BSC.
EIP-1559 was introduced in Ethereum to improve the gas fee pricing mechanism and to make the ETH token more deflationary, as the base fee would be burnt after a transaction was completed. In BSC there is already a burning mechanism in place (BEP-95) so there is no need to burn the base fee. Therefore the base fee will be set to 0, and will
not adjust based on network congestion like in the Ethereum EIP.
3. Specification
Essentially the same gas fee mechanism will be kept in place but the extra
BaseFeefield will be enabled in the header (which will be required to be 0). In addition, theGasTipCap(a.k.a.maxPriorityFeePerGas) andmaxFeePerGasfields will be enabled by using a dynamic transaction type instead of the legacy transaction types. SincebaseFeewill be 0,maxPriorityFeePerGas = maxFeePerGas.The code for EIP-1559 has already been merged from upstream go-ethereum codebase into BSC node codebase, but some custom modifications are still needed (to maintain a constant base fee of 0, and disable extra checks that keep track of the gas utilization over time ) and to ensure everything works correctly before a hard fork enabling this BEP on BSC network.
4. Backwards Compatibility
Legacy transactions will still work and be included in blocks. This is due to the fact that upgrading from legacy transactions to new transactions results in the legacy transaction's
gas_priceentirely being consumed either by thebase_fee_per_gasand thepriority_fee_per_gas.5. License
Copyright and related rights waived via CC0.