Add a missing space to the strings produced for cookie:#38
Merged
Conversation
Collaborator
|
merged and released in 2.1.3 |
Contributor
Author
|
Thank you! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand, the
toValueStringmethod of a list of cookies returned bygetCookiesproduces a string that can be used as a value of theCookiesHTTP header.If so, there is a bug. According to the standard, the cookies must be separated by
;(a semicolon and a space). Browsers follow this standard both in the HTTP header and indocument.cookie. Meanwhilenode-cookiejarseparates the cookies by;(only a semicolon).This is a problem because I use
node-cookiejaras a dependency of superagent, and when I request websites, they parse cookies incorrectly because of the missing space.This PR adds the missing space. Could you please publish the change to NPM?