Apply tar's extract workaround for bun on windows#5
Conversation
c3c7f51 to
4d18912
Compare
|
I think we can keep the tests so we can easily check in the future if the workaround is no longer needed. Thanks! |
|
@ryuapp I ran the tests on master and it seems to not work on windows: https://github.com/bluwy/giget-core/actions/runs/15866068228/job/44733090992. Does it work for you locally? Maybe we should also update tar to v7 in hopes that could indirectly fix things. (#4) |
|
@bluwy However, I have confirmed that it works well on local Windows. |
|
Strange. I've pushed a test commit that undos the workaround, and indeed it the test fails, but in this case the extract silently worked (https://github.com/bluwy/giget-core/actions/runs/15866708618/job/44734898201). Just to confirm, are you using the latest bun version too? I'm a bit afraid to release it with the CI failing, but if I can try to test it later on my windows machine and it works, we could give it a shot. |
Yes. I'm using the latest bun(1.2.17) too. After upgrading tar version to v7, I found that CI is successful: |
|
Interesting, then it's probably easier to just bump to v7 then. Looking at its changelog, its breaking change shouldn't affect us a lot and we can keep the changes as a minor. |
|
Released the fix in v0.1.3 |
closes #3
Apply the patch according to unjs/giget#180, and add a runtime test to check the operation.
It's a hacky CI test, so if you don't need the runtime test, we can remove it.