[WIP/blocked] Factor out runner._report_for_call, using item._current_callinfo#107
Open
[WIP/blocked] Factor out runner._report_for_call, using item._current_callinfo#107
Conversation
3 tasks
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
this is a creative way to sort out the different interaction pattern that unit-test brings about
i hope that my fear is unwarranted (and just a remnant of past changes)
as always, naming is the most difficult
thanks for starting this POC
| #: "teardown", "memocollect" | ||
| start = time() | ||
| excinfo = None | ||
| call = cls( |
There was a problem hiding this comment.
this structure changes a CallInfo from something concrete and state-free to a state-machine tracking the progress if a call
i believe a class name change is warranted to make this clear, but off hand no good name describing it comes to mind
11bbb00 to
588d56d
Compare
588d56d to
b1cee40
Compare
Rebase in the dark...
This reverts commit 3a7daa7.
b1cee40 to
4d578fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: pytest-dev#5996 (comment)
TODO: