feat(precompile): add aws-lc-rs as alternative backend for secp256r1#3451
Merged
feat(precompile): add aws-lc-rs as alternative backend for secp256r1#3451
Conversation
Add `p256-aws-lc-rs` feature flag to use aws-lc-rs instead of the pure Rust p256 crate for secp256r1 (P256) signature verification. The p256 crate remains the default for portability (including zkVMs/wasm).
Member
Author
|
feature was made default and CI passed with it. Fine to merge it |
6232095 to
745581a
Compare
Member
Author
|
it is behind the feature flag, so it is safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p256-aws-lc-rsfeature flag to use aws-lc-rs instead of the pure Rustp256crate for secp256r1 (P256) signature verificationp256crate remains the default for portability (zkVMs, wasm targets)Digest::import_less_safe+UnparsedPublicKey::verify_digestfor prehash verificationCloses #3417
Test plan
secp256r1::testpass withp256-aws-lc-rsfeatureeip7951_p256verify_precompiles/— valid, invalid, wycheproof, gas, call types, etc.)p256backend still works and passes all testscargo fmtandcargo clippyclean