fix(handler): respect is_fee_charge_disabled in calculate_caller_fee#3401
Merged
rakita merged 1 commit intobluealloy:mainfrom Feb 23, 2026
Merged
fix(handler): respect is_fee_charge_disabled in calculate_caller_fee#3401rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
klkvr
approved these changes
Feb 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was testing eth_call with disable_fee_charge=true but fees were still getting deducted. Traced it down to calculate_caller_fee - it checks is_balance_check_disabled but completely skips is_fee_charge_disabled.
Funny thing is op-revm already has this check (handler.rs:158), just missing in the main handler.
Before: fees deducted regardless of config
After: early return with original balance when fee charge disabled