refactor!: flatten Bytecode#3375
Merged
DaniPopes merged 13 commits intobluealloy:mainfrom Feb 5, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c0c85-669b-7035-bdbd-497f1871af9f Co-authored-by: Amp <amp@ampcode.com>
…le, hash Amp-Thread-ID: https://ampcode.com/threads/T-019c0c85-669b-7035-bdbd-497f1871af9f Co-authored-by: Amp <amp@ampcode.com>
- Keep only constants and error types in eip7702.rs - Remove legacy/analyzed.rs and legacy/raw.rs - Move tests to bytecode.rs - Keep BytecodeInner private, only expose BytecodeKind Amp-Thread-ID: https://ampcode.com/threads/T-019c0c85-669b-7035-bdbd-497f1871af9f Co-authored-by: Amp <amp@ampcode.com>
Merging this PR will improve performance by 6.68%
Performance Changes
Comparing 
|
mattsse
requested changes
Jan 30, 2026
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
before we merge any of this I want tests on reth that this doesnt break encoding (again)
meaning that this encodes/decodes the bytecode exactly the same
Collaborator
Author
|
what is it used in? |
Collaborator
Collaborator
Author
|
shouldn't be affected |
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c0c85-669b-7035-bdbd-497f1871af9f
58bdbf3 to
10aa414
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019c1042-1196-768c-aa08-180806a46a13 Co-authored-by: Amp <amp@ampcode.com>
rakita
reviewed
Feb 4, 2026
16d5588 to
b659b04
Compare
Member
|
@mattsse this looks good, no new asserts were added and jumpdest size is same as the previous. iirc I have added few tests when the problem happened previously. I think this is okay to merge, but leave it to your discretion |
mattsse
approved these changes
Feb 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bytecode is now a single struct, with a single enum BytecodeKind for legacy and eip7702