Skip to content
This repository was archived by the owner on Jan 4, 2023. It is now read-only.
This repository was archived by the owner on Jan 4, 2023. It is now read-only.

Protos in with the same file name #309

@loopingrage

Description

@loopingrage

I have a file structure like:

services/foo/foo.proto
common/foo.proto

The two foo.protos declare different packages but for some reason if the service in services/foo/foo.proto imports common/foo.proto the service fails to load. If I simply rename common/foo.proto to something else everything is happy.

I noticed this line that looks suspicious. It seems loadProtos is taking the last token of the file path and using it as a lookup key? Could that be the source of the issue? If so, is there any reason why not to use the full path as the key?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions