fix: windows config location (#8)

cloud-on-prem · web-flow · commit 5694472b1320 · 2025-06-15T15:59:30.000+10:00
diff --git a/README.md b/README.md
@@ -88,6 +88,16 @@ This extension contributes the following settings:
 
 * `goose.enable`: enable/disable this extension
 
+## Configuration File Location
+
+Goose's CLI and this extension look for a configuration file containing
+`GOOSE_PROVIDER` and `GOOSE_MODEL` values. The default locations are:
+
+* **Linux/macOS:** `~/.config/goose/config.yaml`
+* **Windows:** `%APPDATA%\Block\goose\config\config.yaml` (e.g. `C:\Users\<you>\AppData\Roaming\Block\goose\config\config.yaml`)
+
+Ensure this file exists and is populated with valid values before starting the extension.
+
 ----
 
 ## Support
diff --git a/docs/DEVELOPMENT.md b/docs/DEVELOPMENT.md
@@ -8,7 +8,7 @@ For architectural details, see [ARCHITECTURE.md](./ARCHITECTURE.md).
 
 1. Clone the repository
 2. Navigate to the project root directory
-3. Install dependencies: `npm install`
+3. Install dependencies: `npm install` (this installs devDependencies like `rimraf` used by build and test scripts)
 4. Install webview dependencies: `cd webview-ui && npm install && cd ..`
 5. Build the extension and webview: `npm run compile`
 6. Open the project root in VSCode: `code .`
diff --git a/src/test/unit/configReader.test.ts b/src/test/unit/configReader.test.ts
@@ -183,11 +183,12 @@ describe('ConfigReader Tests', () => {
         const pathUsed = readFileSpy.firstCall.args[0];
         
         assert.ok(
-            pathUsed.includes('AppData') && 
-            pathUsed.includes('Roaming') && 
+            pathUsed.includes('AppData') &&
+            pathUsed.includes('Roaming') &&
             pathUsed.includes('Block') &&
             pathUsed.includes('goose') &&
-            pathUsed.includes('config')
+            pathUsed.includes('config') &&
+            pathUsed.endsWith('config.yaml')
         );
         
         // Restore environment
@@ -197,4 +198,43 @@ describe('ConfigReader Tests', () => {
             delete process.env.APPDATA;
         }
     });
+
+    it('should fallback to Roaming when APPDATA is undefined', () => {
+        const readFileSpy = sinon.spy();
+
+        const mockWinOs: OS = {
+            homedir: () => 'C:\\Users\\test',
+            platform: () => 'win32'
+        };
+
+        const mockWinFs: FileSystem = {
+            existsSync: () => true,
+            readFileSync: (path) => {
+                readFileSpy(path);
+                return 'GOOSE_PROVIDER: "databricks"\nGOOSE_MODEL: "claude-3-7-sonnet"';
+            }
+        };
+
+        // Ensure APPDATA is undefined
+        const originalAppData = process.env.APPDATA;
+        delete process.env.APPDATA;
+
+        readGooseConfig(mockWinFs, mockWinOs);
+
+        sinon.assert.calledOnce(readFileSpy);
+        const pathUsed = readFileSpy.firstCall.args[0];
+
+        assert.ok(
+            pathUsed.includes('AppData') &&
+            pathUsed.includes('Roaming') &&
+            pathUsed.includes('Block') &&
+            pathUsed.includes('goose') &&
+            pathUsed.includes('config') &&
+            pathUsed.endsWith('config.yaml')
+        );
+
+        if (originalAppData) {
+            process.env.APPDATA = originalAppData;
+        }
+    });
 });
diff --git a/src/utils/configReader.ts b/src/utils/configReader.ts
@@ -38,13 +38,10 @@ export function getConfigPath(os: OS = osDefault): string | null {
 
     switch (os.platform()) {
         case 'win32':
-            // Windows path: ~\AppData\Roaming\Block\goose\config\config.yaml
-            const appData = process.env.APPDATA;
-            if (!appData) {
-                logger.error('Could not determine APPDATA directory on Windows.');
-                return null; // Return null if APPDATA is not set
-            }
-            // Use appData instead of homeDir for the base path on Windows
+            // Windows path: %APPDATA%\Block\goose\config\config.yaml
+            // Fallback to the typical Roaming path if APPDATA is undefined
+            const appData = process.env.APPDATA ||
+                path.join(homeDir, 'AppData', 'Roaming');
             configPath = path.join(appData, 'Block', 'goose', 'config', 'config.yaml');
             break;
         case 'darwin': // macOS
