Skip to content

feat: add a deep thinking reasoner model (o1-preview/mini)#68

Merged
salman1993 merged 18 commits intomainfrom
o1-reasoner
Oct 10, 2024
Merged

feat: add a deep thinking reasoner model (o1-preview/mini)#68
salman1993 merged 18 commits intomainfrom
o1-reasoner

Conversation

@michaelneale
Copy link
Copy Markdown
Collaborator

@michaelneale michaelneale commented Sep 17, 2024

This starts to introduce the concept of a "slower" reasoner model (alongside accelerator and processor) - and uses it via a toolkit for enhanced debugging/understanding and code authoring.

It will use the o1 models in some cases as needed, to compliment gpt4-o and gpt-4o-mini in the openai case. The "reasoner" model doesn't do tool calling or planning directly, but is consulting.

@michaelneale michaelneale changed the title O1 reasoner feat: add a deep thinking reasoner model Sep 17, 2024
@michaelneale michaelneale changed the title feat: add a deep thinking reasoner model feat: add a deep thinking reasoner model (o1-preview/mini) Sep 17, 2024
Comment thread src/goose/toolkit/reasoner.py Outdated
@michaelneale michaelneale added the enhancement New feature or request label Sep 18, 2024
Comment thread tests/curves/p256_tests.rs Outdated
Copy link
Copy Markdown
Contributor

@wesrblock wesrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@michaelneale michaelneale marked this pull request as ready for review September 19, 2024 07:33
@michaelneale michaelneale requested review from baxen and codefromthecrypt and removed request for codefromthecrypt September 19, 2024 07:33
@michaelneale
Copy link
Copy Markdown
Collaborator Author

I have been using this all week to great success.

@codefromthecrypt
Copy link
Copy Markdown
Collaborator

@michaelneale curious what specific sort of thing do you feel was more effective or possible with this vs without?

@michaelneale
Copy link
Copy Markdown
Collaborator Author

@codefromthecrypt mostly harder problems - for example the "interactive" fix for goose came from it initially (goose wasn't able to solve things that deep before). It also seems to help avoid goose prematurely jumping to a solution by misunderstanding the nuances of a problem and doing a "too obvious" thing. Well worth it IMO (and as a toolkit - so it doesn't kick in all the time).

@michaelneale
Copy link
Copy Markdown
Collaborator Author

@baxen I think this is ready for review - if interested to include it as something people can opt in or not (as toolkit, no extra deps)

@salman1993 salman1993 merged commit 8706e9e into main Oct 10, 2024
ahau-square pushed a commit that referenced this pull request Oct 10, 2024
* main:
  feat: add groq provider (#134)
  feat: add a deep thinking reasoner model (o1-preview/mini) (#68)
  fix: use concrete SessionNotifier (#135)
  feat: add guards to session management (#101)
  fix: Set default model configuration for the Google provider. (#131)
  test: convert Google Gemini tests to VCR (#118)
  chore: Add goose providers list command (#116)
  docs: working ollama for desktop (#125)
  docs: format and clean up warnings/errors (#120)
  docs: update deploy workflow (#124)
  feat: Implement a goose run command (#121)
lukealvoeiro added a commit that referenced this pull request Oct 17, 2024
* main: (23 commits)
  feat: Run with resume session (#153)
  refactor: move langfuse wrapper to a module in exchange instead of a package (#138)
  docs: add subheaders to the 'Other ways to run Goose' section (#155)
  fix: Remove tools from exchange when summarizing files (#157)
  chore: use primitives instead of typing imports and fixes completion … (#149)
  chore: make vcr tests pretty-print JSON (#146)
  chore(release): goose 0.9.5 (#159)
  chore(release): exchange 0.9.5 (#158)
  chore: updates ollama default model from mistral-nemo to qwen2.5 (#150)
  feat: add vision support for Google (#141)
  fix: session resume with arg handled incorrectly (#145)
  docs: add release instructions to CONTRIBUTING.md (#143)
  docs: add link to action, IDE words (#140)
  docs: goosehints doc fix only (#142)
  chore(release): release 0.9.4 (#136)
  revert: "feat: add local langfuse tracing option  (#106)" (#137)
  feat: add local langfuse tracing option  (#106)
  feat: add groq provider (#134)
  feat: add a deep thinking reasoner model (o1-preview/mini) (#68)
  fix: use concrete SessionNotifier (#135)
  ...
@lamchau lamchau deleted the o1-reasoner branch October 24, 2024 11:45
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
jamadeo pushed a commit that referenced this pull request Apr 13, 2026
* feat: add image paste support to chat input

Users can now paste screenshots and images directly into the chat input with Cmd+V. Pasted images show as thumbnails with a click-to-expand lightbox and a hover-reveal remove button. Images are forwarded to the ACP agent as base64 content blocks alongside the text prompt.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: update ChatInput tests for new images argument

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: scope object URL cleanup to unmount only

Revoke only runs on component unmount (via a ref to latest images),
not on every add/remove. Previously the effect's cleanup re-ran on
every images state change, revoking URLs that were still in use.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: render image content blocks in message timeline

Add 'image' case to renderContentBlock in MessageBubble so pasted
images appear in the chat history after sending. Base64 sources are
rendered as data: URLs; URL sources rendered directly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: handle image-only sends and clean up debug logs

- Pass a single space as prompt when images are present but text is empty,
  preventing goose from rejecting empty-text ACP content blocks
- Make images in the message timeline clickable via lightbox (ClickableImage)
- Suppress Radix Dialog aria-describedby warning in ImageLightbox
- Remove temporary debug console.logs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add drag-and-drop image support to chat input

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor: extract ClickableImage to fix file-size lint limit

MessageBubble.tsx was 516 lines (limit 500). Moves ClickableImage
into its own file to bring it under the limit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants