Merged
Conversation
Upgrades JRuby CI builds from 10.0 to 10.0.4.0 and setup-ruby from v1.288.0 to v1.295.0 across all workflow files. JRuby patches updated for 10.0.4.0 compatibility: - Remove the `< 10.0.4.0` version gate so patches remain active. - Remove Bug 1 (Data.new splat forwarding) — fixed upstream in 10.0.4.0 (jruby/jruby#9215, jruby/jruby#9225). - Keep Bug 2 (Data#to_h/deconstruct on subclasses) — still needed, now applied via a Data.define hook since JRuby 10.0.4.0 defines to_h directly on each Data.define subclass. - Work around a new JRuby 10.0.4.0 bug where `include`-ing a module in a Data.define block causes subclass instances to have nil fields in certain call patterns. Fix by defining instance methods directly in the Data.define block instead of using `include InstanceMethods`.
myronmarston
requested changes
Mar 24, 2026
Collaborator
myronmarston
left a comment
There was a problem hiding this comment.
Can any of the patches in https://github.com/block/elasticgraph/blob/main/elasticgraph-schema_definition/lib/elastic_graph/schema_definition/jruby_patches.rb be cleaned up as well?
elasticgraph-support/lib/elastic_graph/support/jruby_patches.rb
Outdated
Show resolved
Hide resolved
8ac9685 to
206a28e
Compare
Contributor
Author
|
regarding the patches in here: 9242, although closed, seems only partially fixed. I no longer see the ClassCastException but I can still trigger the spurious keyword argument warning: Here is the new issue i created reporting the bug only partially fixed: jruby/jruby#9328 |
myronmarston
requested changes
Mar 24, 2026
elasticgraph-support/lib/elastic_graph/support/jruby_patches.rb
Outdated
Show resolved
Hide resolved
myronmarston
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.