[legacy-framework] (newapp) Fix tests not working out of box#1323
Merged
flybayer merged 1 commit intoblitz-js:canaryfrom Oct 14, 2020
Merged
[legacy-framework] (newapp) Fix tests not working out of box#1323flybayer merged 1 commit intoblitz-js:canaryfrom
flybayer merged 1 commit intoblitz-js:canaryfrom
Conversation
flybayer
approved these changes
Oct 14, 2020
Member
|
@all-contributors add @peter50216 for code |
|
I've put up a pull request to add @peter50216! 🎉 |
|
I am not sure how you figured this out but this was very helpful and thank you for sharing your solution @peter50216 <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes and their implications?
Currently
blitz new test; cd test; blitz db migrate; blitz testwould fail withThis is caused by react-query has
require("react")inside a folder named react, and adding"."to moduleDirectories seems to make jest add current directory to module path for ALL dependencies.Fix this by using
"<rootDir>"instead of".".