Allow using Date as a value#26
Conversation
|
Ah, thank you! This was my mistake, tried to make it stricter to avoid user error. Do you have any opinion on expanding types vs just making it |
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 1 1
Lines 45 45
Branches 6 6
=======================================
Hits 43 43
Misses 2 2
Continue to review full report at Codecov.
|
I like that there's some type safety there, but trying to support every use case people will have without just making it any/unknown is probably futile, since anything that can be stringified should be fair game. Also thanks for the quick merge & release! |
Both pg and mysql allow you to pass Date instances as values and do the correct transformation for you.
This was allowed in sql-template-tag as well until the
Valuetype was made more strict in d1fb92e.