Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

synopsysctl prints pvc defaults in mock mode#999

Merged
1 commit merged intoblackducksoftware:release-2019.10.xfrom
mphammer:mock-pvc-values
Oct 18, 2019
Merged

synopsysctl prints pvc defaults in mock mode#999
1 commit merged intoblackducksoftware:release-2019.10.xfrom
mphammer:mock-pvc-values

Conversation

@mphammer
Copy link
Contributor

No description provided.

Copy link
Contributor

@yashbhutwala yashbhutwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionality, works fine.

image

@yashbhutwala
Copy link
Contributor

passing the ball to either @msenmurugan or @jdartigalongue to lgtm, based on any edge cases

/assign @jdartigalongue

Closes #868

@ghost ghost assigned jdartigalongue Oct 17, 2019
@yashbhutwala
Copy link
Contributor

/cherrypick release-2019.11.x

@ghost
Copy link

ghost commented Oct 17, 2019

@yashbhutwala: once the present PR merges, I will cherry-pick it on top of release-2019.11.x in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-2019.11.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msenmurugan
Copy link
Contributor

/lgtm

@ghost ghost assigned msenmurugan Oct 18, 2019
@ghost ghost added the lgtm label Oct 18, 2019
@ghost
Copy link

ghost commented Oct 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mphammer, msenmurugan, yashbhutwala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mphammer,msenmurugan,yashbhutwala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msenmurugan
Copy link
Contributor

/cherrypick release-2019.11.x

@ghost
Copy link

ghost commented Oct 18, 2019

@msenmurugan: once the present PR merges, I will cherry-pick it on top of release-2019.11.x in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-2019.11.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost merged commit 4f341b9 into blackducksoftware:release-2019.10.x Oct 18, 2019
@ghost
Copy link

ghost commented Oct 18, 2019

@yashbhutwala: new pull request created: #1001

Details

In response to this:

/cherrypick release-2019.11.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants