Skip to content

[PM-3833] Remove deprecated register and prelogin from API #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hinton wants to merge 1 commit into from
Closed

[PM-3833] Remove deprecated register and prelogin from API #3255

Hinton wants to merge 1 commit into from

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Sep 8, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove the deprecated register and prelogin endpoints from the API service. I also moved the request and responses into the identity project and removed the duplicated test.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton requested a review from a team as a code owner September 8, 2023 12:07
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 8, 2023

Logo
Checkmarx One – Scan Summary & Details – 964b88f9-8e65-440a-a49e-ffb972d8d537

Fixed Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 323 Attack Vector

JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for cleaning this up!

@JaredSnider-Bitwarden JaredSnider-Bitwarden mentioned this pull request Jun 19, 2024
Merged
@JaredSnider-Bitwarden
Copy link
Contributor

JaredSnider-Bitwarden commented Jun 19, 2024

Closing this in favor of #4206.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hinton @bitwarden-bot @JaredSnider-Bitwarden