Merged
Conversation
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10285 +/- ##
=======================================
Coverage 32.37% 32.38%
=======================================
Files 2655 2655
Lines 80913 80914 +1
Branches 15253 15253
=======================================
+ Hits 26197 26204 +7
+ Misses 52699 52693 -6
Partials 2017 2017 ☔ View full report in Codecov by Sentry. |
Contributor
|
No New Or Fixed Issues Found |
5 tasks
shane-melton
requested changes
Jul 29, 2024
| alg: Number(params.alg), | ||
| type: params.type, | ||
| })) | ||
| .filter((params) => isNaN(params.alg)), |
Member
There was a problem hiding this comment.
.filter((params) => !isNaN(params.alg)), to exclude any NaN values
shane-melton
previously approved these changes
Jul 30, 2024
jprusik
approved these changes
Aug 12, 2024
shane-melton
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-6125
📔 Objective
Converts
kp.algto numbers. This PR is based on #7832 but moves the fix to outside theFido2Clientso that we can keep that service strictly spec-compliant. Original commit is still present in the PR so @AlessioC31 should still be marked as contributor📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes