fix(session): ensure proper cleanup of inflight messages on publish failure#2
Merged
bittcrafter merged 2 commits intomasterfrom Aug 31, 2025
Merged
fix(session): ensure proper cleanup of inflight messages on publish failure#2bittcrafter merged 2 commits intomasterfrom
bittcrafter merged 2 commits intomasterfrom
Conversation
…ailure - Added error mapping to remove inflight entry if `publish()` fails - Separated ACK sending from publish operation for better error handling - Guaranteed inflight message cleanup in both success and error cases This prevents resource leaks when QoS 1 message publishing fails by ensuring the inflight tracking is properly maintained.
- Replaced `map_err` with `inspect_err` for cleaner error side effects - Maintains same functionality: removes inflight entry on publish failure - More idiomatic Rust error handling pattern - Keeps original error unchanged while performing cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish()failsThis prevents resource leaks when QoS 1 message publishing fails by ensuring the inflight tracking is properly maintained.