Skip to content

Remove SonarCloud cache and threads configuration as it is now by default#2736

Merged
abitmore merged 1 commit intobitshares:sonarcloud-configurationfrom
mpaladin:sonarcloud-configuration
Mar 24, 2023
Merged

Remove SonarCloud cache and threads configuration as it is now by default#2736
abitmore merged 1 commit intobitshares:sonarcloud-configurationfrom
mpaladin:sonarcloud-configuration

Conversation

@mpaladin
Copy link
Contributor

No need to configure the cache and threads anymore,
SonarCloud now has automatic analysis caching. See:
https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Testing.

@abitmore abitmore changed the base branch from develop to sonarcloud-configuration March 24, 2023 22:47
@abitmore
Copy link
Member

The Sonar-Scan workflow failed as usual at the last step (uploading results) due to permission issues (the workflow is unable to access the SONAR_TOKEN environment variable), see https://github.com/bitshares/bitshares-core/actions/runs/4512485037/jobs/7951321836?pr=2736

ERROR: Error during SonarScanner execution
ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

I'm merging it into a new branch in the repository to make progress.

@abitmore abitmore merged commit 43ea51e into bitshares:sonarcloud-configuration Mar 24, 2023
@abitmore
Copy link
Member

Proceeding with #2737.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"sonar.cfamily.cache.enabled" and "sonar.cfamily.cache.path" properties are deprecated

2 participants