Skip to content

Lower log level of unfillable_price exception in liqudity_pool_exchange_operation#2625

Merged
abitmore merged 1 commit intodevelopfrom
pr-2543-suppress-p2p-logging
Aug 10, 2022
Merged

Lower log level of unfillable_price exception in liqudity_pool_exchange_operation#2625
abitmore merged 1 commit intodevelopfrom
pr-2543-suppress-p2p-logging

Conversation

@abitmore
Copy link
Member

@abitmore abitmore commented Aug 9, 2022

For #2543.

Specifically, the unfillable_price exception,
usually due to competition among trading bots.
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Aug 9, 2022
@abitmore
Copy link
Member Author

abitmore commented Aug 9, 2022

macOS build failed with error:

2022-08-09T22:18:48.6623510Z �[0;39;49m/Users/runner/work/bitshares-core/bitshares-core/tests/tests/history_api_tests.cpp:602: �[1;31;49merror: in "history_api_tests/track_account2": check histories.size() == 0u has failed [1 != 0]�[0;39;49m

Will retry.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@abitmore abitmore marked this pull request as ready for review August 10, 2022 06:17
@abitmore abitmore merged commit bd01d9a into develop Aug 10, 2022
@abitmore abitmore deleted the pr-2543-suppress-p2p-logging branch August 10, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maybe suppress p2p logging about liquidity pool "Unable to exchange at expected price"

1 participant