Transfer prompt improvements (block list warning + memo handling + i18n fixes)#189
Merged
sschiessl-bcp merged 9 commits intobitshares:developfrom Sep 9, 2022
grctest:transferMemo
Merged
Transfer prompt improvements (block list warning + memo handling + i18n fixes)#189sschiessl-bcp merged 9 commits intobitshares:developfrom grctest:transferMemo
sschiessl-bcp merged 9 commits intobitshares:developfrom
grctest:transferMemo
Conversation
Fix bitsharesjs reference
If memo exists, show it
Reduce risk of falling victim to transfer scams
Contributor
Author
Member
|
@grctest thanks for the efforts. If you don't already know, please check bitshares/bitshares-ui#3454 (comment) for potential issues related to memo encryption. |
Member
|
BTW @sschiessl-bcp made some efforts about memo in #171, perhaps it helps. |
Contributor
Author
|
I'll adapt the changes #171 made for the latest beet version. |
Member
|
I think #171 is a bit outdated. Please check bitshares/bitshares-ui#3454 (comment). |
Also introduced support for optionalNonce & optionally disabling memo encryption
Contributor
Author
|
Alright, I've introduced the bitshares-ui implementation for memo encryption, this allows for unencrypted memo as well as the optional nonce value. |
Addresses: #191
Contributor
Author
|
This PR has been further extended to support changing i18n locales, you're now able to switch between English & German with a button click in the headers. |
Add locale select component to prompts Add a new settingstore getter function for locale
Contributor
Author
|
The i18n component was added to prompts 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix bitsharesjs reference
Show memo in transfer prompt if it exists