Skip to content

Transfer prompt improvements (block list warning + memo handling + i18n fixes)#189

Merged
sschiessl-bcp merged 9 commits intobitshares:developfrom
grctest:transferMemo
Sep 9, 2022
Merged

Transfer prompt improvements (block list warning + memo handling + i18n fixes)#189
sschiessl-bcp merged 9 commits intobitshares:developfrom
grctest:transferMemo

Conversation

@grctest
Copy link
Contributor

@grctest grctest commented Sep 1, 2022

Fix bitsharesjs reference
Show memo in transfer prompt if it exists

image

Fix bitsharesjs reference
If memo exists, show it
Reduce risk of falling victim to transfer scams
@grctest
Copy link
Contributor Author

grctest commented Sep 1, 2022

If the user is prompted to transfer assets on the bitshares blockchain to an account which is blocked by committee-blacklist-manager they will be shown a warning now:

image

@grctest grctest mentioned this pull request Sep 1, 2022
@abitmore
Copy link
Member

abitmore commented Sep 1, 2022

@grctest thanks for the efforts. If you don't already know, please check bitshares/bitshares-ui#3454 (comment) for potential issues related to memo encryption.

@abitmore
Copy link
Member

abitmore commented Sep 1, 2022

BTW @sschiessl-bcp made some efforts about memo in #171, perhaps it helps.

@grctest
Copy link
Contributor Author

grctest commented Sep 1, 2022

I'll adapt the changes #171 made for the latest beet version.

@abitmore
Copy link
Member

abitmore commented Sep 2, 2022

I think #171 is a bit outdated. Please check bitshares/bitshares-ui#3454 (comment).

Also introduced support for optionalNonce & optionally disabling memo encryption
@grctest
Copy link
Contributor Author

grctest commented Sep 2, 2022

Alright, I've introduced the bitshares-ui implementation for memo encryption, this allows for unencrypted memo as well as the optional nonce value.

@grctest grctest changed the title Transfer memo Transfer prompt improvements (block list warning + memo handling) Sep 4, 2022
@grctest grctest mentioned this pull request Sep 4, 2022
@grctest
Copy link
Contributor Author

grctest commented Sep 5, 2022

This PR has been further extended to support changing i18n locales, you're now able to switch between English & German with a button click in the headers.

@grctest grctest changed the title Transfer prompt improvements (block list warning + memo handling) Transfer prompt improvements (block list warning + memo handling + i18n fixes) Sep 5, 2022
Add locale select component to prompts
Add a new settingstore getter function for locale
@grctest
Copy link
Contributor Author

grctest commented Sep 8, 2022

The i18n component was added to prompts 👍

@sschiessl-bcp sschiessl-bcp merged commit 0144964 into bitshares:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants